fix: add gen_ai common attributes to execute_event_loop_cycle spans#2067
Open
Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Open
fix: add gen_ai common attributes to execute_event_loop_cycle spans#2067Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Zelys-DFKH wants to merge 1 commit intostrands-agents:mainfrom
Conversation
start_event_loop_cycle_span() was initializing its attributes dict manually, omitting the gen_ai.system/gen_ai.provider.name and gen_ai.operation.name attributes produced by _get_common_attributes(). All other span start methods (start_model_invoke_span, start_tool_call_span, start_agent_span, start_multiagent_span) call _get_common_attributes() first. This made execute_event_loop_cycle spans inconsistent and broke downstream OTEL tooling that filters on these common identification attributes. The fix calls _get_common_attributes(operation_name="execute_event_loop_cycle") in start_event_loop_cycle_span(), consistent with the other span methods. Resolves strands-agents#1876
Zelys-DFKH
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Zelys-DFKH
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
start_event_loop_cycle_span() initializes its attributes dict manually,
omitting the gen_ai.system / gen_ai.provider.name and gen_ai.operation.name
attributes produced by _get_common_attributes(). The four other span-start
methods (start_model_invoke_span, start_tool_call_span, start_agent_span,
start_multiagent_span) all call _get_common_attributes() first. This made
execute_event_loop_cycle spans inconsistent: they carry gen_ai.input.messages
(promoted by _add_event_messages()) but lack the identification attributes that
downstream OTEL tooling (collectors, exporters, redaction processors) relies on
for filtering.
The fix calls _get_common_attributes(operation_name="execute_event_loop_cycle")
at the start of start_event_loop_cycle_span(), consistent with the other span
methods.
Related Issues
Resolves #1876
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.